davidradl commented on code in PR #26326:
URL: https://github.com/apache/flink/pull/26326#discussion_r2006056894
##########
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java:
##########
@@ -527,23 +527,41 @@ public static String[] mergeListsToArray(List<String>
base, List<String> append)
* open. Unlimited be default.
*/
public static ConfigOption<Integer> fileSystemConnectionLimit(String
scheme) {
- return ConfigOptions.key("fs." + scheme +
".limit.total").intType().defaultValue(-1);
+ return ConfigOptions.key("fs." + scheme + ".limit.total")
+ .intType()
+ .defaultValue(-1)
+ .withDescription(
+ "The connection limit for the file system "
+ + scheme
+ + ". The valid value must >= -1. Values of -1
or 0 will be ignored.");
Review Comment:
nits:
- will be ignored -> mean there is no connection limit
- could you add the documentation for this option with the same description
please.
- I think the description should describe or point to what the scheme is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
