davidradl commented on code in PR #26385:
URL: https://github.com/apache/flink/pull/26385#discussion_r2022493492
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -719,6 +750,32 @@ public boolean dropView(String path, boolean
ignoreIfNotExists) {
return catalogManager.dropView(identifier, ignoreIfNotExists);
}
+ @Override
+ public boolean dropModel(String path) {
+ return dropModel(path, true);
+ }
+
+ @Override
+ public boolean dropModel(String path, boolean ignoreIfNotExists) {
+ Preconditions.checkNotNull(path, "Path must not be null.");
Review Comment:
I am wondering whether it should return false for a null path. rather than
throwing an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
