[ https://issues.apache.org/jira/browse/FLINK-37559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938503#comment-17938503 ]
Chanhyeong Cho edited comment on FLINK-37559 at 3/26/25 1:19 PM: ----------------------------------------------------------------- I think it would be helpful if there is a replaceable gauge in InternalSinkCommitterMetricGroup. The gauge has a delegate of 'CommittableCollector::getNumPending' and replaces delegate on 'copy()' called. The gauge is registered once if before there is no delegate before. If you don't mind me contributing, I'd like to make changes. If there is a better way, I'll follow that. was (Author: JIRAUSER309009): I think it would be helpful if there is a replaceable gauge in InternalSinkCommitterMetricGroup. The gauge has a delegate of 'CommittableCollector::getNumPending' and replaces delegate on 'copy()' called. The gauge is registered once if before there is no delegate before. If you don't mind to contribute, I'd like to make changes. If there is a better way, I'll follow that. > Produce warn log whenever CommitterOperator#snapshotState called > ---------------------------------------------------------------- > > Key: FLINK-37559 > URL: https://issues.apache.org/jira/browse/FLINK-37559 > Project: Flink > Issue Type: Bug > Affects Versions: 1.20.1 > Reporter: Chanhyeong Cho > Priority: Major > > Too many 'pendingCommittables' Name collision logs are produced due to the > reasons mentioned in the title. > > {code:java} > Name collision: Group already contains a Metric with the name > 'pendingCommittables'. Metric will not be reported.[<ip address>, > taskmanager, <tm host>, <job name>, <task name>: Committer, <task index>] > {code} > We've started use flink 1.20.1, and don't know about previous versions. > I guess this occurs after change of > https://issues.apache.org/jira/browse/FLINK-36455 > ([https://github.com/apache/flink/pull/25547]). > > CommitterOperator#snapshotState raise CommittableCollector#copy, and that > calls > SinkCommitterMetricGroup#setCurrentPendingCommittablesGauge which registers > 'pendingCommittables' gauge into metricGroup. > Because the 'pendingCommittables' gauge was already registered at creation > time, it produces warn message at every 'copy()' called. > -- This message was sent by Atlassian Jira (v8.20.10#820010)