beliefer commented on code in PR #26334:
URL: https://github.com/apache/flink/pull/26334#discussion_r2007609847
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/PekkoRpcServiceUtils.java:
##########
@@ -294,15 +290,20 @@ public PekkoRpcServiceBuilder withCustomConfig(final
Config customConfig) {
@Override
public PekkoRpcServiceBuilder withBindAddress(final String
bindAddress) {
- this.bindAddress = Preconditions.checkNotNull(bindAddress);
+ if (bindAddress != null) {
Review Comment:
In fact, we must ensure `bindAddress` is not null. All the code paths show
that check the value like below.
```
if (bindAddress != null) {
rpcServiceBuilder.withBindAddress(bindAddress);
}
```
So the `Preconditions.checkNotNull` is meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
