lvyanquan commented on code in PR #3966:
URL: https://github.com/apache/flink-cdc/pull/3966#discussion_r2011647763
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PreCommitOperator.java:
##########
@@ -110,17 +110,15 @@ public void snapshotState(StateSnapshotContext context)
throws Exception {
super.snapshotState(context);
long checkpointId = context.getCheckpointId();
if (!multiTableCommittables.isEmpty()) {
- multiTableCommittables.forEach(
- (multiTableCommittable) ->
- LOGGER.debug(
- "Try to commit for {}.{} : {} in
checkpoint {}",
- multiTableCommittable.getDatabase(),
- multiTableCommittable.getTable(),
- multiTableCommittables,
- checkpointId));
WrappedManifestCommittable wrappedManifestCommittable =
storeMultiCommitter.combine(checkpointId, checkpointId,
multiTableCommittables);
+ long commitStart = System.currentTimeMillis();
storeMultiCommitter.commit(Collections.singletonList(wrappedManifestCommittable));
+ LOGGER.info(
+ "Commit for {} in checkpoint {} takes {} ms",
+ wrappedManifestCommittable,
Review Comment:
In some cases where users have reported data loss or anomalies, we need to
rely on commit information for troubleshooting.
However, if we adjust the log level of the job later, it may not reflect the
previous situation.
Therefore, I suggest changing it to the info level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
