morazow commented on code in PR #26335:
URL: https://github.com/apache/flink/pull/26335#discussion_r2011503553
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/testTableSourceSinks.scala:
##########
@@ -329,12 +330,18 @@ class TestPartitionableTableSource(
override def explainSource(): String = {
if (remainingPartitions != null) {
- s"partitions=${remainingPartitions.mkString(", ")}"
+ s"partitions=${sortPartitionKeys(remainingPartitions).mkString(", ")}"
Review Comment:
Hey @xuyangzhong,
Thanks for the feedback!
I noticed this part on my initial investigations. But since the issue path
goes through LegacyTable, I ended up here:
```
org.apache.flink.table.planner.plan.rules.logical.PushPartitionIntoLegacyTableSourceScanRuleTest.testWithUdf(PushPartitionIntoLegacyTableSourceScanRuleTest.scala:179)
at java.base/java.lang.reflect.Method.invoke(Method.java:569) at
```
Should I address PartitionPushDownSpec in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
