beliefer opened a new pull request, #26338:
URL: https://github.com/apache/flink/pull/26338

   ## What is the purpose of the change
   
   This PR aims to short circuit judgment for create blob storage dir
   According to 
https://github.com/apache/flink/blob/df058589affe786f5dcbf253cd3769502c28b207/flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/WorkingDirectory.java#L49
   So there are already existing the blob storage dir.
   The original judgment executes `baseDir.mkdirs()` first, but it returns 
false. And then we need to execute `baseDir.exists()`.
   We can only need execute `baseDir.exists()` first and short circuit judgment 
for `baseDir.mkdirs()`.
   According to the current code path, I think this is the mainly logic.
   And this PR will not lead to any regression even if there exists some corner 
case. 
   
   
   ## Brief change log
   
   Short circuit judgment for create blob storage dir
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to