yuxiqian commented on code in PR #3957:
URL: https://github.com/apache/flink-cdc/pull/3957#discussion_r2009433702
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java:
##########
@@ -521,7 +527,24 @@ private String validateTableAndReturnDebeziumStyle(String
tables) {
+ " was enabled.");
}
- return tables.replace("\\.", ".");
+ // Essentially, we're just trying to swap escaped `\\.` and unescaped
`.`.
+ // In our table matching syntax, `\\.` means RegEx token matcher and
`.` means database &
+ // table name separator.
+ // On the contrary, while we're matching TableId string, `\\.` means
matching the "dot"
+ // literal and `.` is the meta-character.
+
+ // Step 1: escape the dot with a backslash, but keep it as a
placeholder (like `$`).
+ // For example, `db\.*.tbl\.*` => `db$*.tbl$*`
+ String unescapedTables = tables.replace("\\.", DOT_PLACEHOLDER);
+
+ // Step 2: replace all remaining dots (`.`) to quoted version (`\.`),
as a separator between
+ // database and table names.
+ // For example, `db$*.tbl$*` => `db$*\.tbl$*`
+ String unescapedTablesWithDbTblSeparator =
unescapedTables.replace(".", "\\.");
+
+ // Step 3: restore placeholder to normal RegEx matcher (`.`)
+ // For example, `db$*\.tbl$*` => `db.*\.tbl.*`
+ return unescapedTablesWithDbTblSeparator.replace(DOT_PLACEHOLDER, ".");
Review Comment:
Good idea, addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
