loserwang1024 commented on PR #3874: URL: https://github.com/apache/flink-cdc/pull/3874#issuecomment-2746720174
This idea looks good to me, which will help imporve a lot. I have some advice: 1. we can do this before add stream split. When adding stream split, we can do what org.apache.flink.cdc.connectors.base.source.meta.split.StreamSplit#forwardHighWatermarkToStartingOffset does. It will reduce the memory better than just skipping emit. 2. please also do it in IncrementalSourceReader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
