[
https://issues.apache.org/jira/browse/FLINK-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753967#comment-15753967
]
ASF GitHub Bot commented on FLINK-5336:
---------------------------------------
GitHub user tonycox opened a pull request:
https://github.com/apache/flink/pull/3018
[FLINK-5336] Remove IOReadableWritable interface from Path
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
make Path's uri final
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tonycox/flink immutablePath
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3018.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3018
----
commit cd20c83edb52bf783850a136d0d57a5b111df5bf
Author: tonycox <tonyco...@gmail.com>
Date: 2016-12-16T09:20:53Z
[FLINK-5336] Remove IOReadableWritable interface from Path, make Path's uri
final
----
> Make Path immutable
> -------------------
>
> Key: FLINK-5336
> URL: https://issues.apache.org/jira/browse/FLINK-5336
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: Stephan Ewen
> Assignee: Anton Solovev
> Fix For: 2.0.0
>
>
> The {{Path}} class is currently mutable to support the {{IOReadableWritable}}
> serialization. Since that serialization is not used any more, I suggest to
> drop that interface from Path and make the Path's URI final.
> Being immutable, we can store configures paths properly without the chance of
> them being mutated as side effects.
> Many parts of the code make the assumption that the Path is immutable, being
> susceptible to subtle errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
