[ https://issues.apache.org/jira/browse/FLINK-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753235#comment-15753235 ]
ASF GitHub Bot commented on FLINK-5324: --------------------------------------- GitHub user hzyuemeng1 reopened a pull request: https://github.com/apache/flink/pull/2994 [FLINK-5324] [yarn] JVM Opitons will work for both YarnApplicationMas… Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html). In addition to going through the list, please provide a meaningful description of your changes. - [ ] General - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text") - The pull request addresses only one issue - Each commit in the PR has a meaningful commit message (including the JIRA id) - [ ] Documentation - Documentation has been added for new functionality - Old documentation affected by the pull request has been updated - JavaDoc for public methods has been added - [ ] Tests & Build - Functionality added by the pull request is covered by tests - `mvn clean verify` has been executed successfully locally or a Travis build has passed …terRunner and YarnTaskManager with yarn mode You can merge this pull request into a Git repository by running: $ git pull https://github.com/hzyuemeng1/flink FLINK-5324 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2994.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2994 ---- commit 0a11b26adfac91663023aa1c5e26e2ff60d44e15 Author: hzyuemeng1 <hzyueme...@corp.netease.com> Date: 2016-12-13T08:13:20Z [FLINK-5324] [yarn] JVM Opitons will work for both YarnApplicationMasterRunner and YarnTaskManager with yarn mode ---- > JVM Opitons will be work both for YarnApplicationMasterRunner and > YarnTaskManager with yarn mode > ------------------------------------------------------------------------------------------------ > > Key: FLINK-5324 > URL: https://issues.apache.org/jira/browse/FLINK-5324 > Project: Flink > Issue Type: Bug > Components: YARN > Affects Versions: 1.1.3 > Reporter: yuemeng > Priority: Critical > Attachments: > 0001-FLINK-5324-yarn-JVM-Opitons-will-work-for-both-YarnA.patch > > > YarnApplicationMasterRunner and YarnTaskManager both use follow code to get > jvm options > {code} > final String javaOpts = > flinkConfiguration.getString(ConfigConstants.FLINK_JVM_OPTIONS, "") > {code} > so when we add some jvm options for one of them ,it will be both worked -- This message was sent by Atlassian JIRA (v6.3.4#6332)