davidradl commented on code in PR #26273:
URL: https://github.com/apache/flink/pull/26273#discussion_r1991724107
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -2218,7 +2218,9 @@ public static LocalStreamEnvironment
createLocalEnvironment() {
* @return A local execution environment with the specified parallelism.
*/
public static LocalStreamEnvironment createLocalEnvironment(int
parallelism) {
- return createLocalEnvironment(parallelism, new Configuration());
+ Configuration configuration = new Configuration();
+ configuration.set(CoreOptions.DEFAULT_PARALLELISM, parallelism);
+ return createLocalEnvironment(configuration);
Review Comment:
@beliefer I found
[https://flink.apache.org/how-to-contribute/code-style-and-quality-java/
](https://flink.apache.org/how-to-contribute/code-style-and-quality-java/ ) but
it does not include this example.
I was only thinking to not define variables if we can avoid it. As the
committer @1996fanrui WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
