davidradl commented on code in PR #26277: URL: https://github.com/apache/flink/pull/26277#discussion_r1986949751
########## docs/layouts/shortcodes/generated/sink_configuration.html: ########## @@ -0,0 +1,18 @@ +<table class="configuration table table-bordered"> + <thead> + <tr> + <th class="text-left" style="width: 20%">Key</th> + <th class="text-left" style="width: 15%">Default</th> + <th class="text-left" style="width: 10%">Type</th> + <th class="text-left" style="width: 55%">Description</th> + </tr> + </thead> + <tbody> + <tr> + <td><h5>sink.committer.retries</h5></td> + <td style="word-wrap: break-word;">10</td> + <td>Integer</td> + <td>The number of retries a Flink application attempts for committable operations (such as transactions) on retriable errors, as specified by the sink connector, before Flink fails and potentially restarts.</td> Review Comment: nits: I see we have copied: "committable operations (such as transactions)" I do t think this reads well. An operation can take part in a transaction - but is not a transaction Flink fails -> don't we mean the Flink application / job fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org