twalthr commented on code in PR #26282:
URL: https://github.com/apache/flink/pull/26282#discussion_r1989655691
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/rules/ResolveCallByArgumentsRule.java:
##########
@@ -108,24 +116,34 @@ private static class ResolvingCallVisitor
public List<ResolvedExpression> visit(UnresolvedCallExpression
unresolvedCall) {
final FunctionDefinition definition;
// clean functions that were not registered in a catalog
- if (!unresolvedCall.getFunctionIdentifier().isPresent()) {
+ if (unresolvedCall.getFunctionIdentifier().isEmpty()) {
definition =
prepareInlineUserDefinedFunction(unresolvedCall.getFunctionDefinition());
} else {
definition = unresolvedCall.getFunctionDefinition();
}
- final String name =
+ final String functionName =
unresolvedCall
.getFunctionIdentifier()
.map(FunctionIdentifier::toString)
.orElseGet(definition::toString);
final Optional<TypeInference> typeInference =
getOptionalTypeInference(definition);
+ // Reorder named arguments and add replacements for optional ones
+ if (definition == BuiltInFunctionDefinitions.ASSIGNMENT) {
+ throw new ValidationException(
Review Comment:
This line is meant for cases where ASSIGNMENT is used outside of a function
call, i.e. as a top level expression. I will add more meaningful comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
