[ 
https://issues.apache.org/jira/browse/FLINK-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751341#comment-15751341
 ] 

ASF GitHub Bot commented on FLINK-4611:
---------------------------------------

Github user tony810430 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2914#discussion_r92583846
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
 ---
    @@ -87,18 +87,6 @@ public void testUnrecognizableAwsRegionInConfig() {
        }
     
        @Test
    -   public void 
testCredentialProviderTypeDefaultToBasicButNoCredentialsSetInConfig() {
    --- End diff --
    
    The new behaviors might be tested in `AWSUtil.getCredentialsProvider()`. I 
think the test in `validateAwsConfiguration()` is enough.


> Make "AUTO" credential provider as default for Kinesis Connector
> ----------------------------------------------------------------
>
>                 Key: FLINK-4611
>                 URL: https://issues.apache.org/jira/browse/FLINK-4611
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kinesis Connector
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Wei-Che Wei
>             Fix For: 1.2.0
>
>
> Right now, the Kinesis Consumer / Producer by default directly expects the 
> access key id and secret access key to be given in the config properties.
> This isn't a good practice for accessing AWS services, and usually Kinesis 
> users would most likely be running their Flink application in AWS instances 
> that have embedded credentials that can be access via the default credential 
> provider chain. Therefore, it makes sense to change the default 
> {{AWS_CREDENTIALS_PROVIDER}} to {{AUTO}} instead of {{BASIC}}.
> To avoid breaking user code, we only use directly supplied AWS credentials if 
> both access key and secret key is given through {{AWS_ACCESS_KEY}} and 
> {{AWS_SECRET_KEY}}. Otherwise, the default credential provider chain is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to