lvyanquan commented on code in PR #3812:
URL: https://github.com/apache/flink-cdc/pull/3812#discussion_r1988229313
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java:
##########
@@ -267,7 +268,13 @@ public DataSource createDataSource(Context context) {
}
String metadataList = config.get(METADATA_LIST);
List<MySqlReadableMetadata> readableMetadataList =
listReadableMetadata(metadataList);
- return new MySqlDataSource(configFactory, readableMetadataList);
+ Configuration pipelineConfiguration =
context.getPipelineConfiguration();
+ boolean isBatchMode = false;
+ if (pipelineConfiguration != null
+ &&
pipelineConfiguration.contains(PipelineOptions.PIPELINE_BATCH_MODE_ENABLED)) {
+ isBatchMode =
pipelineConfiguration.get(PipelineOptions.PIPELINE_BATCH_MODE_ENABLED);
+ }
+ return new MySqlDataSource(configFactory, isBatchMode,
readableMetadataList);
Review Comment:
No such constructor method for MySqlDataSource.
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/common/SchemaDerivator.java:
##########
@@ -341,4 +354,50 @@ public Optional<DataChangeEvent> coerceDataRecord(
return Optional.of(dataChangeEvent);
}
+
+ /** Deduce merged CreateTableEvent in batch mode. */
+ public static List<CreateTableEvent>
deduceMergedCreateTableEventInBatchMode(
Review Comment:
Please add an unit test for this method.
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSource.java:
##########
@@ -81,7 +81,6 @@ public EventSourceProvider getEventSourceProvider() {
(sourceReaderMetrics, sourceConfig) ->
new MySqlPipelineRecordEmitter(
deserializer, sourceReaderMetrics,
sourceConfig));
-
Review Comment:
Unnecessary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
