davidradl commented on code in PR #26263: URL: https://github.com/apache/flink/pull/26263#discussion_r1983498049
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/EventTimeTemporalJoinRewriteRule.java: ########## @@ -28,7 +28,7 @@ import org.apache.flink.table.planner.plan.schema.TimeIndicatorRelDataType; import org.apache.flink.table.planner.plan.utils.TemporalTableJoinUtil; -import org.apache.flink.shaded.curator5.org.apache.curator.shaded.com.google.common.collect.Lists; +import org.apache.flink.shaded.guava33.com.google.common.collect.Lists; Review Comment: We should use the non shaded version and get rid of shaded imports unless there is a really good reason to keep them. Other parts of the table planner use the non shaded version as an import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
