zlzhang0122 created FLINK-37431: ----------------------------------- Summary: We should use guava Lists instead of curator shade Lists to avoid unnecessary error Key: FLINK-37431 URL: https://issues.apache.org/jira/browse/FLINK-37431 Project: Flink Issue Type: Improvement Components: Table SQL / Planner Affects Versions: 1.20.1, 1.19.1, 1.18.1, 2.0.0, 1.20.2 Reporter: zlzhang0122 Fix For: 2.1.0, 2.0.1
In the module flink-table-planner, the [EventTimeTemporalJoinRewriteRule|import org.apache.flink.shaded.curator5.org.apache.curator.shaded.com.google.common.collect.Lists;] use zookeeper curator shade Lists. I think maybe we can use guava Lists instead, other wise there maybe occur lack of jar when we didn't package the flink-shaded-zookeeper-3 explicitly, which didn't package in the flink-dist jar. {code:java} java.lang.NoClassDefFoundError: org/apache/flink/shaded/curator5/org/apache/curator/shaded/com/google/common/collect/Lists at org.apache.flink.table.planner.plan.rules.logical.EventTimeTemporalJoinRewriteRule.onMatch(EventTimeTemporalJoinRewriteRule.java:102) at org.apache.calcite.plan.AbstractRelOptPlanner.fireRule(AbstractRelOptPlanner.java:333) at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:542) at org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:407) at org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:243) at org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:127) at org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:202) at org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:189) at org.apache.flink.table.planner.plan.optimize.program.FlinkHepProgram.optimize(FlinkHepProgram.scala:64) at org.apache.flink.table.planner.plan.optimize.program.FlinkHepRuleSetProgram.optimize(FlinkHepRuleSetProgram.scala:78) at org.apache.flink.table.planner.plan.optimize.program.FlinkGroupProgram.$anonfun$optimize$2(FlinkGroupProgram.scala:59) at scala.collection.TraversableOnce.$anonfun$foldLeft$1(TraversableOnce.scala:156) at scala.collection.TraversableOnce.$anonfun$foldLeft$1$adapted(TraversableOnce.scala:156) at scala.collection.Iterator.foreach(Iterator.scala:937) at scala.collection.Iterator.foreach$(Iterator.scala:937) at scala.collection.AbstractIterator.foreach(Iterator.scala:1425) at scala.collection.IterableLike.foreach(IterableLike.scala:70) at scala.collection.IterableLike.foreach$(IterableLike.scala:69) at scala.collection.AbstractIterable.foreach(Iterable.scala:54) at scala.collection.TraversableOnce.foldLeft(TraversableOnce.scala:156) at scala.collection.TraversableOnce.foldLeft$(TraversableOnce.scala:154) at scala.collection.AbstractTraversable.foldLeft(Traversable.scala:104) at org.apache.flink.table.planner.plan.optimize.program.FlinkGroupProgram.$anonfun$optimize$1(FlinkGroupProgram.scala:56) {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)