yuxiqian commented on code in PR #3939:
URL: https://github.com/apache/flink-cdc/pull/3939#discussion_r1982945203
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformFilter.java:
##########
@@ -41,11 +42,17 @@ public class TransformFilter implements Serializable {
private final String expression;
private final String scriptExpression;
private final List<String> columnNames;
+ private final Map<String, String> columnNameMap;
- public TransformFilter(String expression, String scriptExpression,
List<String> columnNames) {
+ public TransformFilter(
+ String expression,
+ String scriptExpression,
+ List<String> columnNames,
+ Map<String, String> columnNameMap) {
Review Comment:
IIUC `TransformFilter` is static and will not be refreshed after schema
changes, but `columnNameMap` might be changed by altering columns. Will
inserting columns in the middle affect the numbering system?
`ProjectionColumn` looks fine (since projection stuff should be recreated
every time when schema changes), but still need to be verified by an IT case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
