Lzgpom commented on code in PR #188:
URL:
https://github.com/apache/flink-connector-aws/pull/188#discussion_r1981100443
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/KinesisShardSplitReaderBase.java:
##########
@@ -50,10 +49,10 @@
/** Base implementation of the SplitReader for reading from
KinesisShardSplits. */
@Internal
public abstract class KinesisShardSplitReaderBase
- implements SplitReader<Record, KinesisShardSplit> {
+ implements SplitReader<KinesisClientRecord, KinesisShardSplit> {
Review Comment:
I have been looking at the implications of not changing from `Record` into
`KinesisClientRecord` and this is what I have found:
- The deaggreated records would have to be converted from
`KinesisClientRecord`, since `AggregatorUtil` only uses `KinesisClientRecord`,
to `Record` adding a slight overhead.
- The `KinesisClientRecord` has the `subSequenceNumber` that could and
should be used for checkpointing.
Apart from that I don't see any more issues. Either way I don't mind
changing it back to `Record`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
