ChaomingZhangCN commented on code in PR #3883:
URL: https://github.com/apache/flink-cdc/pull/3883#discussion_r1978689655
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksDataSinkOptions.java:
##########
@@ -73,6 +73,14 @@ public class StarRocksDataSinkOptions {
.defaultValue(30000)
.withDescription("Timeout in millisecond for connecting to
the `load-url`.");
+ public static final ConfigOption<Integer> SINK_SOCKET_TIMEOUT =
+ ConfigOptions.key("sink.socket.timeout-ms")
Review Comment:
done
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksDataSinkOptions.java:
##########
@@ -73,6 +73,14 @@ public class StarRocksDataSinkOptions {
.defaultValue(30000)
.withDescription("Timeout in millisecond for connecting to
the `load-url`.");
+ public static final ConfigOption<Integer> SINK_SOCKET_TIMEOUT =
+ ConfigOptions.key("sink.socket.timeout-ms")
+ .intType()
+ .defaultValue(-1)
+ .withDescription(
+ "Supported since 1.2.10. The time duration for
which the HTTP client waits for data."
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
