nilmadhab commented on PR #26235: URL: https://github.com/apache/flink/pull/26235#issuecomment-2692641710
> Thanks for the contribution. > > 1. Every PR/commit should start with prefix either `[hotfix]` or `[FLINK-<jira_issue_number>]`. > 2. What is the reason to have this commit based on Jan 2024 (more than 1 year old)? As a result wrong ci was started for that. > 3. It doesn't make sense to have changes only in one place while there is a huge variety of other places using `docker-compose`. > 4. Also it would make sense to have in docs what was tested. Currently existing tests use `docker-compose`. So would make sense to change both with tests I have created a Jira ticket, please assign it to me, I will update it in all places. https://issues.apache.org/jira/browse/FLINK-37408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
