hlteoh37 commented on code in PR #190:
URL: 
https://github.com/apache/flink-connector-aws/pull/190#discussion_r1973552564


##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/DynamoDbStreamsSource.java:
##########
@@ -133,13 +135,20 @@ public SourceReader<T, DynamoDbStreamsShardSplit> 
createReader(
         setUpDeserializationSchema(readerContext);
 
         Map<String, DynamoDbStreamsShardMetrics> shardMetricGroupMap = new 
ConcurrentHashMap<>();
+        final Duration getRecordsIdlePollingTimeBetweenNonEmptyPolls =
+                
sourceConfig.get(DYNAMODB_STREAMS_GET_RECORDS_IDLE_TIME_BETWEEN_NON_EMPTY_POLLS);
+        final Duration getRecordsIdlePollingTimeBetweenEmptyPolls =
+                
sourceConfig.get(DYNAMODB_STREAMS_GET_RECORDS_IDLE_TIME_BETWEEN_EMPTY_POLLS);

Review Comment:
   Let's add documentation for this. What is the default?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to