MOBIN-F commented on code in PR #3925: URL: https://github.com/apache/flink-cdc/pull/3925#discussion_r1967096754
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonMetadataApplierTest.java: ########## @@ -441,6 +441,13 @@ public void testAddColumnWithPosition(String metastore) tableSchema, catalog.getTable(Identifier.fromString("test.table1")).rowType()); addedColumns.clear(); + + addedColumns.add( + AddColumnEvent.before( + Column.physicalColumn( + "col4_first_before", + org.apache.flink.cdc.common.types.DataTypes.STRING()), + "col1")); Review Comment: The before column is actually derived in [schemaUtils](https://github.com/apache/flink-cdc/blob/e7964b160c1df3861571ba2199ba04d91d887ff2/flink-cdc-common/src/main/java/org/apache/flink/cdc/common/utils/SchemaUtils.java#L239). If the transform is defined in the pipeline ``` transform: - source-table: dw_app.test_table projection: __table_name__ as table_name,\* primary-keys: id ``` At this time, when add column first is executed in the mysql table, the [add column first] event will become the [add column before] event. If no transform is defined, add first first event remains the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org