davidradl commented on code in PR #138:
URL:
https://github.com/apache/flink-connector-kafka/pull/138#discussion_r1965271755
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/FlinkKafkaInternalProducer.java:
##########
@@ -156,6 +157,11 @@ public List<PartitionInfo> partitionsFor(String topic) {
return kafkaProducer.metrics();
}
+ @Override
Review Comment:
I would suggest we should still unit test all new methods even if they are
added into a deprecated class as they are supported and could introduce bugs. I
am not sure what others in the community think - I will go with a consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
