autophagy commented on code in PR #43:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/43#discussion_r1963579142
##########
python/lint-python.sh:
##########
@@ -377,73 +375,62 @@ function install_environment() {
print_function "STAGE" "installing environment"
local sys_os=`uname -s`
- #get the index of the SUPPORT_OS array for convinient to intall tool.
+ #get the index of the SUPPORT_OS array for convenient to install tool.
get_os_index $sys_os
local os_index=$?
- # step-1 install wget
- # the file size of the miniconda.sh is too big to use "wget" tool to
download instead
- # of the "curl" in the weak network environment.
+ # step-1 install uv
if [ $STEP -lt 1 ]; then
- print_function "STEP" "installing wget..."
- install_wget ${SUPPORT_OS[$os_index]}
- STEP=1
- checkpoint_stage $STAGE $STEP
- print_function "STEP" "install wget... [SUCCESS]"
- fi
-
- # step-2 install miniconda
- if [ $STEP -lt 2 ]; then
- print_function "STEP" "installing miniconda..."
+ print_function "STEP" "installing uv..."
create_dir $CURRENT_DIR/download
- install_miniconda $os_index
- STEP=2
+ install_uv
+ STEP=1
checkpoint_stage $STAGE $STEP
- print_function "STEP" "install miniconda... [SUCCESS]"
+ print_function "STEP" "install uv... [SUCCESS]"
fi
- # step-3 install python environment which includes
+ # step-2 install python environment which includes
# 3.7 3.8 3.9 3.10
- if [ $STEP -lt 3 ] && [ `need_install_component "py_env"` = true ]; then
+ if [ $STEP -lt 2 ] && [ `need_install_component "py_env"` = true ]; then
print_function "STEP" "installing python environment..."
install_py_env
- STEP=3
+ STEP=2
checkpoint_stage $STAGE $STEP
print_function "STEP" "install python environment... [SUCCESS]"
fi
- # step-4 install tox
- if [ $STEP -lt 4 ] && [ `need_install_component "tox"` = true ]; then
+ # step-3 install tox
+ if [ $STEP -lt 3 ] && [ `need_install_component "tox"` = true ]; then
print_function "STEP" "installing tox..."
install_tox
- STEP=4
+ STEP=3
checkpoint_stage $STAGE $STEP
print_function "STEP" "install tox... [SUCCESS]"
fi
- # step-5 install flake8
- if [ $STEP -lt 5 ] && [ `need_install_component "flake8"` = true ]; then
+ # step-4 install flake8
+ if [ $STEP -lt 4 ] && [ `need_install_component "flake8"` = true ]; then
print_function "STEP" "installing flake8..."
install_flake8
- STEP=5
+ STEP=4
checkpoint_stage $STAGE $STEP
print_function "STEP" "install flake8... [SUCCESS]"
fi
- # step-6 install sphinx
- if [ $STEP -lt 6 ] && [ `need_install_component "sphinx"` = true ]; then
+ # step-5 install sphinx
+ if [ $STEP -lt 5 ] && [ `need_install_component "sphinx"` = true ]; then
print_function "STEP" "installing sphinx..."
install_sphinx
- STEP=6
+ STEP=5
checkpoint_stage $STAGE $STEP
print_function "STEP" "install sphinx... [SUCCESS]"
fi
- # step-7 install mypy
- if [[ ${STEP} -lt 7 ]] && [[ `need_install_component "mypy"` = true ]];
then
+ # step-5 install mypy
Review Comment:
Oops, yes, good catch 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
