lvyanquan commented on code in PR #3791:
URL: https://github.com/apache/flink-cdc/pull/3791#discussion_r1962921992


##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/DataChangeEvent.java:
##########
@@ -40,11 +40,22 @@ private DataChangeEvent(
             RecordData after,
             OperationType op,
             Map<String, String> meta) {
+        this(tableId, before, after, op, meta, null);
+    }
+
+    private DataChangeEvent(
+            TableId tableId,
+            RecordData before,
+            RecordData after,
+            OperationType op,
+            Map<String, String> meta,

Review Comment:
   What about putting schema info in meta directly, and add one kind of 
MySqlReadableMetadata to extract it from SourceRecord.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to