morhidi commented on code in PR #945:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/945#discussion_r1962071572
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##########
@@ -149,19 +149,31 @@ public CollectedMetricHistory updateMetrics(
// Add scaling metrics to history if they were computed successfully
metricHistory.put(now, scalingMetrics);
- if (isStabilizing) {
- LOG.info("Stabilizing until {}", readable(stableTime));
- stateStore.storeCollectedMetrics(ctx, metricHistory);
- return new CollectedMetricHistory(topology,
Collections.emptySortedMap(), jobRunningTs);
- }
-
var collectedMetrics = new CollectedMetricHistory(topology,
metricHistory, jobRunningTs);
if (now.isBefore(windowFullTime)) {
- LOG.info("Metric window not full until {}",
readable(windowFullTime));
+ if (isStabilizing) {
+ LOG.info(
+ "Stabilizing... until {}. {} samples collected",
Review Comment:
Correct me if I'm wrong but samples are collected during stabilization
period and used in evaluated metrics after exiting the stabilization period. We
only drop the history when the window is full
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
