bvarghese1 commented on code in PR #25753: URL: https://github.com/apache/flink/pull/25753#discussion_r1957702535
########## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/over/NonTimeRangeUnboundedPrecedingFunctionTest.java: ########## @@ -0,0 +1,2028 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.over; + +import org.apache.flink.api.common.state.MapState; +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.streaming.api.operators.KeyedProcessOperator; +import org.apache.flink.streaming.api.watermark.Watermark; +import org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness; +import org.apache.flink.table.data.GenericRowData; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.data.StringData; +import org.apache.flink.table.data.binary.BinaryRowData; +import org.apache.flink.table.data.utils.JoinedRowData; +import org.apache.flink.table.runtime.generated.GeneratedRecordComparator; +import org.apache.flink.table.runtime.generated.GeneratedRecordEqualiser; +import org.apache.flink.table.runtime.generated.RecordComparator; +import org.apache.flink.table.runtime.generated.RecordEqualiser; +import org.apache.flink.table.runtime.keyselector.RowDataKeySelector; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.types.logical.BigIntType; +import org.apache.flink.table.types.logical.IntType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.VarCharType; +import org.apache.flink.table.utils.HandwrittenSelectorUtil; +import org.apache.flink.types.RowKind; + +import org.junit.Test; + +import java.time.Duration; +import java.util.Arrays; +import java.util.List; +import java.util.concurrent.atomic.AtomicInteger; + +import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord; +import static org.apache.flink.table.runtime.util.StreamRecordUtils.updateAfterRecord; +import static org.apache.flink.table.runtime.util.StreamRecordUtils.updateBeforeRecord; +import static org.assertj.core.api.Assertions.assertThat; + +/** Test for {@link NonTimeRangeUnboundedPrecedingFunction}. */ +public class NonTimeRangeUnboundedPrecedingFunctionTest extends RowTimeOverWindowTestBase { + + private static final int SORT_KEY_IDX = 1; + + private static final LogicalType[] SORT_KEY_TYPES = new LogicalType[] {new BigIntType()}; + + private static final InternalTypeInfo<RowData> INPUT_ROW_TYPE = + InternalTypeInfo.ofFields(VarCharType.STRING_TYPE, new BigIntType(), new IntType()); + + private static final RowDataKeySelector SORT_KEY_SELECTOR = + HandwrittenSelectorUtil.getRowDataSelector( + new int[] {SORT_KEY_IDX}, INPUT_ROW_TYPE.toRowFieldTypes()); + + private static final GeneratedRecordComparator GENERATED_SORT_KEY_COMPARATOR_ASC = + new GeneratedRecordComparator("", "", new Object[0]) { + + private static final long serialVersionUID = 1L; + + @Override + public RecordComparator newInstance(ClassLoader classLoader) { + return new LongRecordComparator(0, true); + } + }; + + private static final GeneratedRecordComparator GENERATED_SORT_KEY_COMPARATOR_DESC = + new GeneratedRecordComparator("", "", new Object[0]) { + + private static final long serialVersionUID = 1L; + + @Override + public RecordComparator newInstance(ClassLoader classLoader) { + return new LongRecordComparator(0, false); + } + }; + + private static final GeneratedRecordEqualiser GENERATED_ROW_VALUE_EQUALISER = + new GeneratedRecordEqualiser("", "", new Object[0]) { + + private static final long serialVersionUID = 1L; + + @Override + public RecordEqualiser newInstance(ClassLoader classLoader) { + return new TestRowValueEqualiser(); + } + }; + + private static final GeneratedRecordEqualiser GENERATED_SORT_KEY_EQUALISER = + new GeneratedRecordEqualiser("", "", new Object[0]) { + + private static final long serialVersionUID = 1L; + + @Override + public RecordEqualiser newInstance(ClassLoader classLoader) { + return new TestSortKeyEqualiser(); + } + }; + + /** Custom test comparator for comparing numbers. */ + public static class LongRecordComparator implements RecordComparator { + + private int pos; + private boolean isAscending; + + public LongRecordComparator(int pos, boolean isAscending) { + this.pos = pos; + this.isAscending = isAscending; + } + + @Override + public int compare(RowData o1, RowData o2) { + boolean null0At1 = o1.isNullAt(pos); + boolean null0At2 = o2.isNullAt(pos); + int cmp0 = + null0At1 && null0At2 + ? 0 + : (null0At1 + ? -1 + : (null0At2 + ? 1 + : Long.compare(o1.getLong(pos), o2.getLong(pos)))); + if (cmp0 != 0) { + if (isAscending) { + return cmp0; + } else { + return -cmp0; + } + } + return 0; + } + } + + /** Custom test row equaliser for comparing rows. */ + public static class TestRowValueEqualiser implements RecordEqualiser { + + private static final long serialVersionUID = -6706336100425614942L; + + @Override + public boolean equals(RowData row1, RowData row2) { + if (row1 instanceof BinaryRowData && row2 instanceof BinaryRowData) { + return row1.equals(row2); + } else if (row1 instanceof GenericRowData && row2 instanceof GenericRowData) { + return row1.getString(0).equals(row2.getString(0)) + && row1.getLong(1) == row2.getLong(1) + && row1.getLong(2) == row2.getLong(2); + } else { + throw new UnsupportedOperationException(); + } + } + } + + /** Custom test sortKey equaliser for comparing sort keys. */ + public static class TestSortKeyEqualiser implements RecordEqualiser { + + private static final long serialVersionUID = -6706336100425614942L; + + @Override + public boolean equals(RowData row1, RowData row2) { + if (row1 instanceof BinaryRowData && row2 instanceof BinaryRowData) { + return row1.equals(row2); + } else if (row1 instanceof GenericRowData && row2 instanceof GenericRowData) { + return row1.getLong(0) == row2.getLong(0); + } else { + throw new UnsupportedOperationException(); + } + } + } + + @Test + public void testInsertOnlyRecordsWithCustomSortKey() throws Exception { + NonTimeRangeUnboundedPrecedingFunction<RowData> function = + new NonTimeRangeUnboundedPrecedingFunction<RowData>( + 0, + aggsHandleFunction, + GENERATED_ROW_VALUE_EQUALISER, + GENERATED_SORT_KEY_EQUALISER, + GENERATED_SORT_KEY_COMPARATOR_ASC, + accTypes, + inputFieldTypes, + SORT_KEY_TYPES, + SORT_KEY_SELECTOR) {}; + KeyedProcessOperator<RowData, RowData, RowData> operator = + new KeyedProcessOperator<>(function); + + OneInputStreamOperatorTestHarness<RowData, RowData> testHarness = + createTestHarness(operator); + + testHarness.open(); + + // put some records + testHarness.processElement(insertRecord("key1", 1L, 100L)); + testHarness.processElement(insertRecord("key1", 2L, 200L)); + testHarness.processElement(insertRecord("key1", 5L, 500L)); + testHarness.processElement(insertRecord("key1", 6L, 600L)); + testHarness.processElement(insertRecord("key2", 1L, 100L)); + testHarness.processElement(insertRecord("key2", 2L, 200L)); + + testHarness.processWatermark(new Watermark(500L)); + + // out of order record should trigger updates for all records after its inserted position + testHarness.processElement(insertRecord("key1", 4L, 400L)); + + List<RowData> expectedRows = + Arrays.asList( + new JoinedRowData( Review Comment: Refactored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
