davidradl commented on code in PR #26157:
URL: https://github.com/apache/flink/pull/26157#discussion_r1956259835
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala:
##########
@@ -227,6 +232,11 @@ object WindowUtil {
}
val slide = getOperandAsLong(windowCall.operands(2))
val size = getOperandAsLong(windowCall.operands(3))
+ if (slide <= 0 || size <= 0) {
+ throw new TableException(
+ s"HOP table function based aggregate requires slide and size being
positive," +
Review Comment:
nit: being -> to be.
nit2: Just a thought we could have a separate message for each invalid
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
