xuyangzhong commented on code in PR #25629:
URL: https://github.com/apache/flink/pull/25629#discussion_r1955449598
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java:
##########
@@ -184,7 +184,11 @@ public static boolean isWindowFired(
/** Method to get the next watermark to trigger window. */
public static long getNextTriggerWatermark(
Review Comment:
Could you please add some UT for this method? This will be more clear to
check the return results.
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/slicing/SliceAssigners.java:
##########
@@ -69,6 +69,12 @@ public static TumblingSliceAssigner tumbling(
return new TumblingSliceAssigner(rowtimeIndex, shiftTimeZone,
size.toMillis(), 0);
}
+ public static TumblingSliceAssigner tumbling(
Review Comment:
Although this simplifies the original `tumbling(...).withOffset(...)`, I
think we'd better not introduce new methods if they are only used for testing
purposes, as it would slightly increase maintenance, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
