davidradl commented on code in PR #26118:
URL: https://github.com/apache/flink/pull/26118#discussion_r1952860352
##########
flink-datastream-api/src/main/java/org/apache/flink/datastream/api/extension/eventtime/function/OneInputEventTimeStreamProcessFunction.java:
##########
@@ -43,5 +43,6 @@ default void onEventTimeWatermark(
* Invoked when an event-time timer fires. Note that it is only used in
{@link
* KeyedPartitionStream}.
*/
- default void onEventTimer(long timestamp, Collector<OUT> output,
PartitionedContext<OUT> ctx) {}
+ default void onEventTimer(long timestamp, Collector<OUT> output,
PartitionedContext<OUT> ctx)
+ throws Exception {}
Review Comment:
I suggest adding javadoc for the parameters and Exception.
nit: I am curious why throws Exception is on these methods rather than just
catching a throwable in some higher level code?
Maybe some words like this method should be overridden ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
