pnowojski commented on PR #26051: URL: https://github.com/apache/flink/pull/26051#issuecomment-2651197059
> check the changelog mode is not I when enabling mini-batch or keeping last row I think they are covered by the existing cases. For example `org.apache.flink.table.planner.plan.stream.sql.DeduplicateTest#testMiniBatchInferFirstRowOnRowtime` for mini batch or `org.apache.flink.table.planner.plan.stream.sql.DeduplicateTest#testSimpleLastRowOnProctime` for last row in plans and we also have ITCases for those. However indeed the `DeduplicateTest` planing tests are relaying on the `COUNT_RETRACT`. I will change them to use `util.verifyExplain(sql, ExplainDetail.CHANGELOG_MODE)`. > I'm sorry for this late reply, please ping me again next time if this pr is ready :) no problem! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
