Zakelly commented on code in PR #26117:
URL: https://github.com/apache/flink/pull/26117#discussion_r1948417578


##########
flink-examples/flink-examples-streaming/src/test/java/org/apache/flink/streaming/test/socket/SocketWindowWordCountITCase.java:
##########
@@ -60,8 +72,15 @@ public void testJavaProgram() throws Exception {
                 serverThread.start();
 
                 final int serverPort = server.getLocalPort();
+                System.out.println("Server listening on port " + serverPort);
 
-                SocketWindowWordCount.main(new String[] {"--port", 
String.valueOf(serverPort)});
+                if (asyncState) {
+

Review Comment:
   Redundant line.



##########
flink-examples/flink-examples-streaming/src/test/java/org/apache/flink/streaming/test/StreamingExamplesITCase.java:
##########
@@ -101,46 +113,40 @@ public Tuple2<String, Integer> map(String value) throws 
Exception {
     @Test
     public void testSessionWindowing() throws Exception {
         final String resultPath = getTempDirPath("result");
+

Review Comment:
   nit. Redundant line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to