hanyuzheng7 commented on code in PR #25897:
URL: https://github.com/apache/flink/pull/25897#discussion_r1948364110
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##########
@@ -1290,6 +1353,24 @@ private static long floor(long a, long b) {
}
}
+ private static long floor(long a, int b) {
Review Comment:
I use a and b just follow other exist method, yes, I think I can rename a
and b and let them more meaningful.
q stand for quotient and r stand for remainder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
