showuon commented on code in PR #26003:
URL: https://github.com/apache/flink/pull/26003#discussion_r1931354609


##########
flink-runtime/src/test/java/org/apache/flink/runtime/memory/MemoryManagerConcurrentModReleaseTest.java:
##########
@@ -97,6 +101,12 @@ public void run() {
                 try {
                     MemorySegment seg = toModify.remove(0);
                     toModify.add(seg);
+                    // if the test running time reaches TEST_TIMEOUT_MS, we 
should lower the
+                    // priority of the Modifier thread to let segment release 
completes sooner.

Review Comment:
   Thanks for the comment @davidradl !
   I've updated the comments and changed to use `exponential sleep` to make it 
much reliable. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to