[
https://issues.apache.org/jira/browse/FLINK-37098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921388#comment-17921388
]
Alexander Fedulov edited comment on FLINK-37098 at 1/27/25 1:49 PM:
--------------------------------------------------------------------
It occurs that {{@PublicEvolving}} include for japicmp remained commented out
on the {{release-1.20}} branch which led to PRs CI passing with the violation
that is not allowed for the releases ([automatically gets uncommented
|https://github.com/apache/flink/blob/c2a76f7a82cee9e089ea89731568f2e522c3ea43/tools/releasing/update_japicmp_configuration.sh#L79]as
part of the release process)
For comparison,
1.18 branch:
[flink/pom.xml|https://github.com/apache/flink/blob/b2a260ac957dac3b6af5dc73684624dd36dc92ea/pom.xml#L2286]
||<include>@org.apache.flink.annotation.PublicEvolving</include>||
1.20 branch:
[flink/pom.xml|https://github.com/apache/flink/blob/4b306699811af0b6ff2cb862914adfda56345996/pom.xml#L2359]
||<!-{-}<include>@org.apache.flink.annotation.PublicEvolving</include>{-}->||
was (Author: afedulov):
It occurs that {{@PublicEvolving}} include for japicmp remained commented out
on the {{release-1.20}} branch which led to PRs CI passing with the violation
that is not allowed for the releases ([automatically gets uncommented
|https://github.com/apache/flink/blob/c2a76f7a82cee9e089ea89731568f2e522c3ea43/tools/releasing/update_japicmp_configuration.sh#L79]as
part of the release process)
For comparison,
1.18 branch:
[flink/pom.xml
|https://github.com/apache/flink/blob/b2a260ac957dac3b6af5dc73684624dd36dc92ea/pom.xml#L2286]
[b2a260a|https://github.com/apache/flink/commit/b2a260ac957dac3b6af5dc73684624dd36dc92ea]
||<include>@org.apache.flink.annotation.PublicEvolving</include>|
1.20 branch:
[flink/pom.xml
|https://github.com/apache/flink/blob/4b306699811af0b6ff2cb862914adfda56345996/pom.xml#L2359]
[4b30669|https://github.com/apache/flink/commit/4b306699811af0b6ff2cb862914adfda56345996]
||<!--<include>@org.apache.flink.annotation.PublicEvolving</include>-->|
> Can not select time attribute from a view
> -----------------------------------------
>
> Key: FLINK-37098
> URL: https://issues.apache.org/jira/browse/FLINK-37098
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.20.1
> Reporter: Dawid Wysakowicz
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0, 1.20.2
>
>
> Unfortunately the solution in [FLINK-36883] is not fully functional, because
> of a check in {{SqlToRelConverter}}. If the time attribute should be returned
> from a query using such a view it will fail with:
> {code}
> Conversion to relational algebra failed to preserve datatypes:
> validated type:
> RecordType(VARCHAR(2147483647) CHARACTER SET "UTF-16LE" NOT NULL order_id,
> INTEGER customer_id, BIGINT product_id, TIMESTAMP_WITH_LOCAL_TIME_ZONE(3) NOT
> NULL $rowtime) NOT NULL
> converted type:
> RecordType(VARCHAR(2147483647) CHARACTER SET "UTF-16LE" NOT NULL order_id,
> INTEGER customer_id, BIGINT product_id, TIMESTAMP_LTZ(3) *ROWTIME* NOT NULL
> $rowtime) NOT NULL
> rel:
> LogicalProject(order_id=[$0], customer_id=[$1], product_id=[$2],
> $rowtime=[$3])
> LogicalProject(order_id=[$0], customer_id=[$1], product_id=[$6],
> $rowtime=[$5])
> LogicalCorrelate(correlation=[$cor0], joinType=[inner],
> requiredColumns=[{2}])
> LogicalWatermarkAssigner(rowtime=[$rowtime],
> watermark=[SOURCE_WATERMARK()])
> LogicalProject(order_id=[$0], customer_id=[$1], product_ids=[$2],
> price=[$3], order_details=[$4], $rowtime=[CAST($5):TIMESTAMP_LTZ(3) *ROWTIME*
> NOT NULL])
> LogicalTableScan(table=[[prod, marketplace, orders,
> metadata=[$rowtime]]])
> LogicalProject(product_id=[$0])
> Uncollect
> LogicalProject(product_ids=[$cor0.product_ids])
> LogicalValues(tuples=[[{ 0 }]])
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
