[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745298#comment-15745298
]
ASF GitHub Bot commented on FLINK-4460:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2982
@chenqin I had a quick look at the implementation and it looks quite good.
I'll look at it in more detail once the 1.2 release is out and then I'll also
have more thorough comments.
These are some quick comments off the top of my head:
- I think we can extend `Collector` with a `collect(OutputTag, T)` method.
Then we wouldn't need the extra `RichCollector` and `CollectorWrapper` to work
around that.
- For `WindowedStream` I would like to have something like this:
```
OutputTag<T> lateElementsOutput = ...;
DataStream<T> input = ...
SingleOutputStreamOperator<O> windowed = input
.keyBy(...)
.window(...)
.apply(Function, lateElementsOutput);
DataStream<T> lateElements = windowed.getSideOutput(lateElementsOutput);
```
or maube something else if we find a better Idea. With the
`WindowedStream.tooLateElements()` this would instantiate an extra
`WindowOperator` just for getting late elements while another window operator
would be responsible for processing the actual elements. That seems wasteful.
What do you think?
> Side Outputs in Flink
> ---------------------
>
> Key: FLINK-4460
> URL: https://issues.apache.org/jira/browse/FLINK-4460
> Project: Flink
> Issue Type: New Feature
> Components: Core, DataStream API
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Chen Qin
> Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
