JunRuiLee commented on code in PR #26025:
URL: https://github.com/apache/flink/pull/26025#discussion_r1923096609


##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PartitionedFileWriteReadTest.java:
##########
@@ -755,7 +762,7 @@ private PartitionedFileWriter createPartitionedFileWriter(
 
     private PartitionedFileWriter createAndFinishPartitionedFileWriter() 
throws IOException {
         PartitionedFileWriter partitionedFileWriter = 
createPartitionedFileWriter(1, new int[0]);
-        partitionedFileWriter.finish();
+        partitionedFileWriter.finish().deleteQuietly();

Review Comment:
   If it's not very straightforward to implement this, I would prefer to 
introduce a property PartitionedFile partitionedFile, and have each case assign 
a value to it. Then, delete it in the AfterEach method.
   For example:
   ```
       private PartitionedFile partitionedFile;
   
       @AfterEach
       void after() {
           partitionedFile.deleteQuietly();
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to