yuxiqian commented on code in PR #3865:
URL: https://github.com/apache/flink-cdc/pull/3865#discussion_r1921735422
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/utils/SchemaUtils.java:
##########
@@ -452,6 +455,43 @@ public static Schema inferWiderSchema(@Nullable Schema
lSchema, Schema rSchema)
return lSchema.copy(mergedColumns);
}
+ public static void validateMetaSchemaCompatibility(LinkedHashSet<Schema>
schemas) {
Review Comment:
My concern is if we're throwing an exception in the utility method, it might
be less universal. But your implementation is more reasonable, because we can't
return any reason message to indicate the incompatible reason by returning a
boolean.
Let's just keep it as is, with just a few changes:
* throwing a checked exception would be better and clearer for any method
callers
* change `LinkedHashSet` to more generic `Collection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
