Zakelly commented on code in PR #25998:
URL: https://github.com/apache/flink/pull/25998#discussion_r1919878519


##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -158,7 +161,8 @@ public AsyncExecutionController(
             int batchSize,
             long bufferTimeout,
             int maxInFlightRecords,
-            SwitchContextListener<K> switchContextListener) {
+            @Nullable SwitchContextListener<K> switchContextListener,
+            @Nullable MetricGroup metricGroup) {

Review Comment:
   Add a child group `asyncStateProcessing` in `AbstractStreamOperator(V2)`, no 
further prefix with in aec



##########
docs/content.zh/docs/ops/metrics.md:
##########
@@ -2280,6 +2282,44 @@ logged by `SystemResourcesMetricsInitializer` during the 
startup.
   </tbody>
 </table>
 
+### Async State Processing
+
+<table class="table table-bordered">
+  <thead>
+    <tr>
+      <th class="text-left" style="width: 15%">Scope</th>
+      <th class="text-left" style="width: 7%">Infix</th>
+      <th class="text-left" style="width: 20%">Metrics</th>
+      <th class="text-left" style="width: 50%">Description</th>
+      <th class="text-left" style="width: 8%">Type</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr>
+      <th rowspan="4"><strong>Operator</strong></th>
+      <td rowspan="4">aec</td>

Review Comment:
   I'd also suggest changing this to `asyncStateProcessing`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to