hackergin commented on code in PR #25946: URL: https://github.com/apache/flink/pull/25946#discussion_r1919776675
########## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogManagerTest.java: ########## @@ -589,6 +600,7 @@ void testCatalogStore() throws Exception { assertTrue(catalogManager.listCatalogs().contains("cat2")); assertTrue(catalogManager.listCatalogs().contains("cat3")); assertTrue(catalogManager.listCatalogs().contains("cat_comment")); + assertFalse(catalogManager.listCatalogs().contains("cat_no_type")); Review Comment: Would it be better to put this assertion together with the above assertThatThrownBy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org