lincoln-lil commented on code in PR #25861:
URL: https://github.com/apache/flink/pull/25861#discussion_r1918422071
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala:
##########
@@ -352,6 +356,21 @@ object WindowUtil {
}
}
+ def isAsyncStateEnabled(
+ config: ReadableConfig,
+ windowAssigner: WindowAssigner,
+ aggInfoList: AggregateInfoList): Boolean = {
+ if (!config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_STATE_ENABLED)) {
+ return false
+ }
+ // currently, unslice assigner does not support async state
Review Comment:
nit: unsliced
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/common/WindowProcessor.java:
##########
@@ -18,22 +18,32 @@
package org.apache.flink.table.runtime.operators.window.tvf.common;
-import org.apache.flink.annotation.Internal;
import org.apache.flink.api.common.functions.RuntimeContext;
import org.apache.flink.api.common.typeutils.TypeSerializer;
import org.apache.flink.runtime.memory.MemoryManager;
-import org.apache.flink.runtime.state.KeyedStateBackend;
import org.apache.flink.streaming.api.operators.InternalTimerService;
import org.apache.flink.table.data.RowData;
+import
org.apache.flink.table.runtime.operators.window.async.tvf.common.AsyncStateWindowProcessor;
import java.io.Serializable;
-/** A processor that processes elements for windows. */
-@Internal
-public interface WindowProcessor<W> extends Serializable {
+/**
+ * A base window processor provides common methods used for {@link
SyncStateWindowProcessor} and
+ * {@link AsyncStateWindowProcessor}.
+ *
+ * @param <W> the window type.
+ * @param <C> the context that provides some information for the window
processor.
+ */
+public interface WindowProcessor<W, C extends WindowProcessor.Context<W>>
extends Serializable {
Review Comment:
Should the `@Internal` annotation be reserved？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
