ryanvanhuuksloot commented on code in PR #25899:
URL: https://github.com/apache/flink/pull/25899#discussion_r1915213621
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointType.java:
##########
@@ -46,6 +46,10 @@ public boolean isSavepoint() {
return false;
}
+ public boolean isFull() {
+ return getSharingFilesStrategy() == SharingFilesStrategy.FORWARD;
Review Comment:
>it should be return getSharingFilesStrategy() ==
SharingFilesStrategy.FORWARD;
🤔
Shouldn't it be the first recommendation you said
https://github.com/apache/flink/pull/25899#discussion_r1912657301
Given that it could be FORWARD or NO_SHARING?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
