suez1224 commented on code in PR #25965:
URL: https://github.com/apache/flink/pull/25965#discussion_r1914308321
##########
flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/BeamPythonFunctionRunner.java:
##########
@@ -681,7 +686,14 @@ public void onCompleted(BeamFnApi.ProcessBundleResponse
response) {
private TimerReceiverFactory createTimerReceiverFactory() {
BiConsumer<Timer<?>, TimerInternals.TimerData> timerDataConsumer =
- (timer, timerData) -> timerRegistration.setTimer((byte[])
timer.getUserKey());
+ (timer, timerData) ->
+ environment
+ .getMainMailboxExecutor()
Review Comment:
I believe the mainMailboxExecutor is set once for the StreamTask here
https://github.com/apache/flink/blob/60497e7dfddf27b25b80b913ef259010e97569aa/flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java#L458.
And when Environment.getMainMainboxExecutor() is called here
https://github.com/apache/flink/blob/60497e7dfddf27b25b80b913ef259010e97569aa/flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/RuntimeEnvironment.java#L376,
it only returns the instance variable directly. I did not see any side effect
in the code, or do I miss anything? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
