xuyangzhong commented on code in PR #25723:
URL: https://github.com/apache/flink/pull/25723#discussion_r1914191986
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java:
##########
@@ -541,8 +541,10 @@ private void processElementWithoutRowNumber(RowData
inputRow, Collector<RowData>
}
}
- private void flushBufferToState(Tuple2<TopNBuffer, Map<RowData, RankRow>>
bufferEntry)
+ private void flushBufferToState(
Review Comment:
As it stands, there is no issue with the append top N. I have placed it
under the Jira ticket for introducing the updatable top N with the async state
API https://issues.apache.org/jira/browse/FLINK-36936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
