Zakelly commented on code in PR #25968:
URL: https://github.com/apache/flink/pull/25968#discussion_r1914125165
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -410,9 +424,11 @@ private void seizeCapacity() {
* (once the record is not blocked).
*
* @param callback the callback to run if it finishes (once the record is
not blocked).
+ * @param overdraft whether to overdraft the in-flight buffer.
*/
- public StateFuture<Void>
syncPointRequestWithCallback(ThrowingRunnable<Exception> callback) {
- return handleRequest(null, StateRequestType.SYNC_POINT, null)
+ public StateFuture<Void> syncPointRequestWithCallback(
+ ThrowingRunnable<Exception> callback, boolean overdraft) {
Review Comment:
I'd name it `allowOverdraft` everywhere. It seems 'overdraught' and
'overdraft' are same but 'overdraft' is more common in github (search the two
words above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
