hackergin commented on code in PR #25784:
URL: https://github.com/apache/flink/pull/25784#discussion_r1912418732


##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -601,6 +601,24 @@ This configuration:
 
 <span class="label label-danger">Attention</span> Compared to the interactive 
mode, SQL Client will stop execution and exits when there are errors.
 
+### Deploy SQL Files in an Application Cluster
+
+SQL Client also supports deploying a SQL script file to an Application Cluster 
with the `-f` option, if you specify the deployment target in the config.yaml 
or startup options.
+Here is an example to deploy script file in an Application Cluster.
+
+```bash 
+./bin/sql-client.sh -f oss://path/to/script.sql \
+      -Dexecution.target=kubernetes-application \
+      -Dkubernetes.cluster-id=${CLUSTER_ID} \
+      -Dkubernetes.container.image.ref=${FLINK_IMAGE_NAME}'
+```
+
+After execution, SQL Client print the cluster id on the terminal. The script 
can contain any statement that is supported by Flink. But Application cluster 
only supports one job, please refer to the 

Review Comment:
   ```suggestion
   After execution, SQL Client will print the cluster id on the terminal. The 
script can contain any statement supported by Flink. But Application cluster 
only supports one job, please refer to the 
   ```



##########
docs/content/docs/dev/table/sql-gateway/overview.md:
##########
@@ -122,6 +122,34 @@ The `nextResultUri` in the results is used to fetch the 
next batch results if it
 $ curl --request GET ${nextResultUri}
 ```
 
+### Deploy Script
+
+SQL Gateway supports deploying a script in [Application Mode]({{< ref 
"docs/deployment/overview" >}}). In application mode, [JobManager]({{< ref 
"docs/concepts/flink-architecture" >}}#jobmanager) is responsible for compiling 
the script.
+If you want to use custom resources in the script, e.g. Kafka Source, please 
use [ADD JAR]({{< ref "docs/dev/table/sql/jar">}}) command to download the 
[required artifacts]({{< ref "docs/dev/configuration/connector" 
>}}#available-artifacts). 
+
+Here is an example to deploy a script to Flink a native K8S Cluster with 
cluster id `CLUSTER_ID`.

Review Comment:
   ```suggestion
   Here is an example for deploying a script to a Flink native K8S Cluster with 
cluster id `CLUSTER_ID`.
   ```



##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -601,6 +601,24 @@ This configuration:
 
 <span class="label label-danger">Attention</span> Compared to the interactive 
mode, SQL Client will stop execution and exits when there are errors.
 
+### Deploy SQL Files in an Application Cluster

Review Comment:
   Deploy SQL Files to an Application Cluster  Or Deploy SQL Files in 
Application Mode  ? 



##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -601,6 +601,24 @@ This configuration:
 
 <span class="label label-danger">Attention</span> Compared to the interactive 
mode, SQL Client will stop execution and exits when there are errors.
 
+### Deploy SQL Files in an Application Cluster
+
+SQL Client also supports deploying a SQL script file to an Application Cluster 
with the `-f` option, if you specify the deployment target in the config.yaml 
or startup options.
+Here is an example to deploy script file in an Application Cluster.
+
+```bash 
+./bin/sql-client.sh -f oss://path/to/script.sql \
+      -Dexecution.target=kubernetes-application \
+      -Dkubernetes.cluster-id=${CLUSTER_ID} \
+      -Dkubernetes.container.image.ref=${FLINK_IMAGE_NAME}'
+```
+
+After execution, SQL Client print the cluster id on the terminal. The script 
can contain any statement that is supported by Flink. But Application cluster 
only supports one job, please refer to the 

Review Comment:
   > any statement that is supported by Flink. But Application cluster only 
supports one job
   
   Are you sure this limitation is correct? If the script contains multiple DML 
statements, shouldn’t it be possible to submit multiple jobs in one application 
cluster ? 



##########
docs/content/docs/dev/table/sql-gateway/overview.md:
##########
@@ -122,6 +122,34 @@ The `nextResultUri` in the results is used to fetch the 
next batch results if it
 $ curl --request GET ${nextResultUri}
 ```
 
+### Deploy Script

Review Comment:
   ```suggestion
   ### Deploying a Script
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to