lvyanquan commented on code in PR #3673: URL: https://github.com/apache/flink-cdc/pull/3673#discussion_r1910115690
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonMetadataApplier.java: ########## @@ -325,14 +317,32 @@ private void applyAlterColumnType(AlterColumnTypeEvent event) throws SchemaEvolv tableChangeList.add( SchemaChangeProvider.updateColumnType( oldName, newType))); - catalog.alterTable( - new Identifier(event.tableId().getSchemaName(), event.tableId().getTableName()), - tableChangeList, - true); + catalog.alterTable(tableIdToIdentifier(event), tableChangeList, true); } catch (Catalog.TableNotExistException | Catalog.ColumnAlreadyExistException | Catalog.ColumnNotExistException e) { throw new SchemaEvolveException(event, e.getMessage(), e); } } + + private void applyTruncateTable(TruncateTableEvent event) throws SchemaEvolveException { + try (BatchTableCommit batchTableCommit = + catalog.getTable(tableIdToIdentifier(event)).newBatchWriteBuilder().newCommit()) { Review Comment: As We are currently experiencing some unexpected situations while truncating table with option of `deletion-vectors.enabled: true`. How about throwing exceptions when truncate these tables? WDYT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org