MartijnVisser commented on code in PR #25898: URL: https://github.com/apache/flink/pull/25898#discussion_r1905181258
########## .github/workflows/nightly.yml: ########## @@ -39,23 +39,12 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }} s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }} - java17: - name: "Java 17" - uses: ./.github/workflows/template.flink-ci.yml - with: - workflow-caller-id: java17 - environment: 'PROFILE="-Dinclude_hadoop_aws -Djdk11 -Djdk17 -Pjava17-target"' - jdk_version: 17 - secrets: - s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} - s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }} - s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }} Review Comment: I believe this is the dedicated job to test Java 17, which would be redundant given that we use 17 by default already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org